Improvement #8129: Fix cdm admin user authorization - Backlog - Entgra.io

Actions

Copy link

Improvement #8129

open

Fix cdm admin user authorization

Added by Entgra Admin almost 2 years ago. Updated 8 months ago.

Status:

New

Priority:

None

Assignee:

Start date:

16/08/2019

Due date:

% Done:

Estimated time:

0:00 h

Device Type:

Component:

Type:

Description

From Gitlab
------------------------
gitlabId --> 130 https://gitlab.com/entgra/product-iots/-/issues/130
labels --> Type: Improvement,
assignees -->
created_at --> 2019-08-16 18:51:53 IST +0530
updated_at --> 2021-10-12 10:06:07 IST +0530
------------------------

if the user has the "/device-mgt/admin" permission<br>
OR
if the user has the "/device-mgt/devices/any-device/permitted-actions-under-owning-device" permission<br>
OR
if the user is the owner of the device

Description
Currently, the authorization of the carbon device-mgt admin role is checked through the "/device-mgt/devices/any-device/permitted-actions-under-owning-device" permission. The isAdminUser(String username, int tenantId) method in DeviceAccessAuthorizationServiceImpl checks if the user is an admin by looking for this permission.<br>
The following improvements are suggested:
1. The "/device-mgt/devices/any-device/permitted-actions-under-owning-device" permission should be renamed as it lacks clarity on what this permission entails.
2. The above permission should be moved to an admin level in the permission tree.
3. The isAdmin method should check for the "/device-mgt/admin" permission and another method should be implemented to check for the above-mentioned permission.
4. Three conditions must be checked to authorize a user:

Related Issues:
https://gitlab.com/entgra/product-iots/issues/31

Actions

Copy link

Updated by Entgra Admin almost 2 years ago

From Gitlab
------------------------
author: tcdlpds
created_at: 2019-09-05 17:18:06 IST +0530
updated_at: 2019-09-05 17:18:06 IST +0530
------------------------

changed milestone to %5

Actions

Copy link

Updated by Entgra Admin almost 2 years ago

From Gitlab
------------------------
author: milanperera
created_at: 2019-09-09 01:49:06 IST +0530
updated_at: 2019-09-09 01:49:06 IST +0530
------------------------

assigned to @milanperera

Actions

Copy link

Updated by Entgra Admin almost 2 years ago

From Gitlab
------------------------
author: tcdlpds
created_at: 2019-10-14 07:42:59 IST +0530
updated_at: 2019-10-14 07:42:59 IST +0530
------------------------

changed milestone to %6

Actions

Copy link

Updated by Entgra Admin almost 2 years ago

From Gitlab
------------------------
author: inosh
created_at: 2020-03-25 12:08:27 IST +0530
updated_at: 2020-03-25 12:08:27 IST +0530
------------------------

changed milestone to %10

Actions

Copy link

Updated by Entgra Admin almost 2 years ago

From Gitlab
------------------------
author: tcdlpds
created_at: 2020-09-16 20:16:01 IST +0530
updated_at: 2020-09-16 20:16:01 IST +0530
------------------------